manaba-enhanced icon indicating copy to clipboard operation
manaba-enhanced copied to clipboard

Published 20 hours ago • verified publisher icon manaba-enhanced-for-tsukuba

refactor: abstraction for features

Open yudukikun5120 opened this issue 2 years ago • 4 comments

This PR enables TSC to detect missing implementation for features and relates to #505 in bringing easiness for listing features.

yudukikun5120 avatar Dec 17 '22 16:12 yudukikun5120

@mkobayashime I regret to say that the commitlint error caused by the commit https://github.com/manaba-enhanced-for-tsukuba/manaba-enhanced/pull/558/commits/67ecf525c6786bbd7aba3169fcefafaf30b60052 can be ignored since the introduction of commitlint follows chronologically the commit.

yudukikun5120 avatar Jan 09 '23 15:01 yudukikun5120

@yudukikun5120 I think what commitlint is asking for is not to use uppercased character (T in the TSC in this case) at the beginning of the subject. chore: tsc can detect... will do for instance.

mkobayashime avatar Jan 10 '23 13:01 mkobayashime

Code Climate has analyzed commit 7f516359 and detected 0 issues on this pull request.

View more on Code Climate.

codeclimate[bot] avatar Jan 10 '23 15:01 codeclimate[bot]

@mkobayashime It is too hard to modify the past commit messages. I think we should skip the commitlint errors in this PR.

yudukikun5120 avatar Jan 10 '23 15:01 yudukikun5120