Notebooker Windows Issues

[beebeed]

Love the project and concepts but having a few issues in getting this up and running on windows 11

1. In window virtual env the executable notebooker-cli is in the script folder so https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/execute_notebook.py#L522 should be replaced by os.path.join(sys.exec_prefix, "Scripts", "notebooker-cli")

2. Babel needs a locale defined https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/utils/results.py#L147 should be replaced by metadata["time_diff"] = babel.dates.format_timedelta(datetime.datetime.now() - metadata["latest_run"], locale = "en")

3. open statements should include encoding="utf-8") https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/execute_notebook.py#L117 https://github.com/man-group/notebooker/blob/d7549c5f1522b90aacb65310922b169e8540b7fd/notebooker/utils/conversion.py#L27 i.e. open(ipynb_path, "r", encoding="utf-8")

4. this still appears to be an issue with a blank results page output https://github.com/man-group/notebooker/issues/77#issuecomment-1062321017

this returns an empty array http://127.0.0.1:11828/core/get_all_available_results?limit=100&report_name=sample/plot_random but this works... it is to do with slashes http://127.0.0.1:11828/core/get_all_available_results?limit=100&report_name=sample\plot_random I couldnt work out where best to fix this... any advice.

[beebeed]

FYI... I think that the windows compatibility started to be looked at in this branch to address slashes issues https://github.com/man-group/notebooker/compare/windows-compat

[jonbannister]

Thanks for the report, we will try to take a look. If you were able to fix locally in the meantime then contributions are very welcome!

[beebeed]

ok... when I get a moment I will submit some fixes