PyBloqs icon indicating copy to clipboard operation
PyBloqs copied to clipboard

Fix bug when export html, chart plotly not show

Open quangduong109 opened this issue 3 years ago • 3 comments

Because the DOM has not finished loading, the require plotly function fails, in fact the require function is an async function, so it cannot be assigned to the Plotly variable. The fix is to replace the text in the returned plot function to pass the Plotly variable into the render chart function. Before fix: image image

quangduong109 avatar Sep 13 '21 17:09 quangduong109

Hi @quangduong109 thanks for the work and PR! Before we can merge, can you please:

  • [ ] Remove all changes except the one in pybloqs/block/image.py - we will do a release ASAP with your doc fix
  • [ ] Squash commits with new message "bugfix - get plotly export to html working with Block"

chazkii avatar Oct 29 '21 10:10 chazkii

Hi @quangduong109 thanks for the work and PR! Before we can merge, can you please:

  • [ ] Remove all changes except the one in pybloqs/block/image.py - we will do a release ASAP with your doc fix
  • [ ] Squash commits with new message "bugfix - get plotly export to html working with Block"

I have updated. Please check and accept this pull request. Thank you ^^

quangduong109 avatar Oct 30 '21 00:10 quangduong109

Hi @quangduong109, thanks, though you haven't squashed your commits - there should only be 1 commit to be merged. Though more importantly, I've just checked out your branch and plotly appears to still be broken, as seen when generating the docs via python setup.py build_sphinx. If you could please demonstrate how your change will fix an existing bug, then we can consider merging. image

chazkii avatar Oct 31 '21 18:10 chazkii