ArcticDB icon indicating copy to clipboard operation
ArcticDB copied to clipboard

Remove non-lmdb stores from unit tests

Open G-D-Petrov opened this issue 9 months ago • 2 comments

Reference Issues/PRs

Fixes #1564

What does this implement or fix?

It remove all simulators from the unit tests (e.g. S3 moto, azurite, mongo)

TODO - make sure that we don't need these tests, if we don - add them to the integration tests

G-D-Petrov avatar May 10 '24 12:05 G-D-Petrov

Moved the test_fork test to integration as it seems sensible to test this with a s3 simulation at least With these changes, locally the unit tests run in ~2min in comperisson to ~7min before them with ARCTICDB_FAST_TEST_ONLY=1 @alexowens90 - do we need to test the QB aggregations with s3/azure simulations or is lmdb enough?

G-D-Petrov avatar May 10 '24 13:05 G-D-Petrov

Are we sure this is a good idea? Azurite and Mongo are quite irritating in that they mostly fail locally, but S3 is the storage that the vast majority of our users actually use. This means we're removing more than half the tests in the whole project from the one storage that actually matters to the majority of people, which seems like a high price to pay for knocking a few minutes off a CI run

willdealtry avatar May 14 '24 18:05 willdealtry