ArcticDB icon indicating copy to clipboard operation
ArcticDB copied to clipboard

Update openssl3 in pypi

Open phoebusm opened this issue 10 months ago • 5 comments

Reference Issues/PRs

#1491

What does this implement or fix?

Update openssl to v3

Any other comments?

Checklist

Checklist for code changes...
  • [ ] Have you updated the relevant docstrings, documentation and copyright notice?
  • [ ] Is this contribution tested against all ArcticDB's features?
  • [ ] Do all exceptions introduced raise appropriate error messages?
  • [ ] Are API changes highlighted in the PR description?
  • [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

phoebusm avatar Apr 11 '24 15:04 phoebusm

Change looks fine. What test coverage do we have for our SSL interaction? Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not.

poodlewars avatar Apr 13 '24 11:04 poodlewars

Change looks fine. What test coverage do we have for our SSL interaction?

https://github.com/man-group/ArcticDB/pull/1338 S3 auto ca path PR has already been merged. It contains the https related tests.

Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not.

Good point. Let me turn it on

phoebusm avatar Apr 15 '24 08:04 phoebusm

Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not.

@poodlewars It is on now.

phoebusm avatar Apr 24 '24 14:04 phoebusm

Do the persistent storage tests use HTTPS? Worth running them if so, or doing a quick manual test if not.

@poodlewars It is on now.

@phoebusm can you share a link showing it passing please?

poodlewars avatar May 13 '24 09:05 poodlewars

@poodlewars

root@XPS:/tmp# cat /etc/*-release | grep PRETTY_NAME
PRETTY_NAME="Ubuntu 22.04.4 LTS"
root@XPS:/tmp# python -m venv venv
root@XPS:/tmp# source venv/bin/activate
(venv) root@XPS:/tmp# pip install arcticdb-4.1.0.dev0-cp310-cp310-manylinux_2_17_x86_64.manylinux2014_x86_64.whl 
(venv) root@XPS:/tmp# python
Python 3.10.12 (main, Nov 20 2023, 15:14:05) [GCC 11.4.0] on linux
Type "help", "copyright", "credits" or "license" for more information.
>>> import arcticdb as adb
>>> arctic = adb.Arctic("s3s://s3-eu-north-1.amazonaws.com:XXXXXXXXXXXX?aws_auth=true&ssl=True")
>>> arctic.list_libraries()
[]
>>> quit()
(venv) root@XPS:/tmp# ls -al /etc/pki/ca-trust/extracted/pem/
ls: cannot access '/etc/pki/ca-trust/extracted/pem/': No such file or directory
(venv) root@XPS:/tmp# ls -al /etc/ssl/certs/ca-certificates.crt
-rw-r--r-- 1 root root 208567 Nov 27 14:45 /etc/ssl/certs/ca-certificates.crt

phoebusm avatar May 14 '24 17:05 phoebusm