ArcticDB
ArcticDB copied to clipboard
man-group
maint: Support protobuf Python library v5
Is your feature request related to a problem? Please describe. Protobuf has released version 5 but we only support version 3 and 4. PR #1421 has constrained protobuf version for now.
We should relax this constraint that we are imposing on user's envs.
Our proto handling is quite complex - we compile Python proto stubs suitable for both proto 3 and proto 4 and choose which a user will "see" at runtime based on their installed proto version.
The solution should consider both wheels and Conda builds.
Currently ArcticDB's conda packages are built for:
-
protobuf 4 on
mainsince there are less constraints and to follow the ecosystem's releases - protobuf 3 for all the other branches to do environment contraints, see the specification for
libevent-2.1.10's for instance
protobuf 5 has not yet been published on conda-forge. https://github.com/conda-forge/libprotobuf-feedstock/pull/213 is the first PR to start this work.
We might need to define a build variant for protobuf 3, 4, and 5 once this last version is supported.
Likely addressable for conda-forge's builds once https://github.com/conda-forge/protobuf-feedstock/pull/216 is completed.
Upgrade to protobuf 5 for pip wheel has been done in #1635. Waiting for https://github.com/conda-forge/protobuf-feedstock/pull/216 for protobuf 5 upgrade of conda
FYI https://github.com/conda-forge/protobuf-feedstock/pull/215 can also be watched (it was started before the bot opened https://github.com/conda-forge/protobuf-feedstock/pull/216).
Protobuf 5 is being released on conda-forge thanks to https://github.com/conda-forge/protobuf-feedstock/pull/215.
ArcticDB can be build for libprotobuf 5 on the feedstock: https://github.com/conda-forge/arcticdb-feedstock/pull/298