ArcticDB icon indicating copy to clipboard operation
ArcticDB copied to clipboard

Fix crash during normalization of time zones

Open G-D-Petrov opened this issue 11 months ago • 1 comments

Reference Issues/PRs

Fixes #1406

What does this implement or fix?

Converts time zone data to string when normalizing with MsgPack. Adds tests to make sure that the crash doesn't reproduce in the future.

Any other comments?

Checklist

Checklist for code changes...
  • [ ] Have you updated the relevant docstrings, documentation and copyright notice?
  • [ ] Is this contribution tested against all ArcticDB's features?
  • [ ] Do all exceptions introduced raise appropriate error messages?
  • [ ] Are API changes highlighted in the PR description?
  • [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?

G-D-Petrov avatar Mar 08 '24 14:03 G-D-Petrov

This PR does change the stored and returned timezone data. We should likely hold off for a major version, just as with #1410 Is the original "Coordinated Universal Time" windows example issue urgent in any way?

jamesmunro avatar Apr 11 '24 12:04 jamesmunro