hacs_waste_collection_schedule
hacs_waste_collection_schedule copied to clipboard
[Bug]: day_switch_time does not seem to be working correctly
I Have A Problem With:
The integration in general
What's Your Problem
I have day switch time set to 20:00
but the day switches at 01:19
config:
waste_collection_schedule:
sources:
- name: maldon_gov_uk
args:
uprn: "uprn"
customize:
- type: Refuse Collection
- type: Recycling
day_switch_time: "20:00"
fetch_time: 01:00
Source (if relevant)
Maldon District Council / maldon.gov.uk
Logs
No response
Relevant Configuration
waste_collection_schedule:
sources:
- name: maldon_gov_uk
args:
uprn: "uprn"
customize:
- type: Refuse Collection
- type: Recycling
day_switch_time: "20:00"
fetch_time: 01:00
Checklist Source Error
- [ ] Use the example parameters for your source (often available in the documentation) (don't forget to restart Home Assistant after changing the configuration)
- [X] Checked that the website of your service provider is still working
- [ ] Tested my attributes on the service provider website (if possible)
- [X] I have tested with the latest version of the integration (master) (for HACS in the 3 dot menu of the integration click on "Redownload" and choose master as version)
Checklist Sensor Error
- [X] Checked in the Home Assistant Calendar tab if the event names match the types names (if types argument is used)
Required
- [X] I have searched past (closed AND opened) issues to see if this bug has already been reported, and it hasn't been.
- [X] I understand that people give their precious time for free, and thus I've done my very best to make this problem as easy as possible to investigate.
It seems like a similar issue to bristol_gov_uk which was raised in issue #1173 and resolved here. Unsure how to make these changes to maldon_gov_uk, though.
This probably happens because the site lists the collections of the current date as 'Last Collection' which is not parsed by the source (not confirmed), so the integration does not find the collection date on parse (~1:00 AM) #2099 should fix this as it also parses the 'Last Collection'.
A fast workaround would be to set the fetch_time to 20:00 (note random_fetch_time_offset defaults to 60 minutes)
This will be part of release 1.49.0 or is available now as master (git) version (3-dot menu -> redownload -> change version to master -> fully restart HA (this will increase update cycle by a lot)