mame
mame copied to clipboard
mamedev
new NOT WORKING machines
new NOT WORKING machines
Interactive M.A.G. Motion Activated Gear: Toy Story and Beyond! Buzz Lightyear Galactic Adventure [Sean Riddle]
this used an unusual 'square' ROM glob, which took a lot of figuring out the pin-out of for Sean.
current ROM data should be in the correct order.
there are likely MCUs in the wearable parts of this though, as they can make sounds etc. without the main unit being turned on (number of parts involved is unknown)
I'm not really sure this can move forward more until further games are dumped using the hardware type , the existing set are not providing what I would call definitive evidence, so I'm done with this for now.
(as always, for the hi-kara user carts somebody with knowledge of Japanese should add the tracks to the xml)
Please split out the simple cartridge additions, and add photos and screenshots so that the titles and track lists can be sorted out before the stuff gets merged. If it isn’t done beforehand, it won’t get done, and it will just add to the generally poor state of software lists.
I'd rather not split things up as it's just extra churn, and the only way I can stay on top of the new dumps is by working with whatever open PR I have. I'll compromise and just remove all code outside of the set additions.
Photos were provided with the ROMs, but I'll put them here too anyway.
reverted the remaining changes, so this is now nothing but simple set additions.
I've removed all credits, as apparently credits are a problem. Just credit [David Haywood] for everything. splitting this by driver wouldn't change the credit situation, as some of the MAGs were dumped by TE and some Sean.
Your list of additions in the pull request description does not have credits for systems or software list item. You did this last month as well resulting in TeamEurope’s cartridge dumps almost being credited to xtrasmiley.
I’ve got the cartridge additions ready to commit locally. Who should be credited for each of the cartridge dumps?
The credits were originally there in the description, but I removed them in response to RB saying items couldn't have different credits in the same PR, as a result I requested that I simply be credited to resolve the issue. (Some of the MAG games were dumped by Sean and some were by Team Europe)
I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.
You’re misrepresenting what @rb6502 – he said that putting additions from different contributor in a single pull request is liable to cause confusion if don’t make it very clear what came from each contributor.
Well every item was individually credited, correctly and clearly, at the point he complained, how else am I meant to interpret it?
I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.
No you aren’t:
- @rb6502 asked you not to mix additions from different contributors in the same pull request to avoid confusion. You’ve done that again.
- I’ve asked you to provide images in pull requests for media where you can’t read the titles. You still won’t do it without being prompted.
- I’ve asked you multiple times to use the wording for list headings in the whatsnew files. You still won’t do that (e.g here you haven’t even separated working and non-working software list additions).
- You’ve been asked not to mix unrelated changes in the same pull request. You keep doing that.
Once again, I have all the cartridge additions ready to commit. Who did the each cartridge come from?
I really wish the team would make up their fucking minds, because I just feel like I'm jumping through hoops only to have to jump backwards through them again here.
You want to constantly accuse me of “rudeness” but you resort to swearing when asked for clarification. Do you fail to see the irony?
The request not to mix additions from different contributors is absolutely fucking ridiculous, the MAG stuff from Team Europe and Sean is in the same driver even. Seems like a new rule is being made up every week.
It isn’t a “rule”. @rb6502 requested that you not mix them because you weren’t making it clear what came from where, leading to confusion and things almost being credited to the wrong people. There’s less chance of that happening if the credits are the same for everything in a single PR.
As for where the cartridges came from, work it out yourself. I've no further inclination to help you. I'm done jumping through hoops.
EVERYTHING was correctly credited before RB asked me to change it. EVERYTHING was clear and if you don't fucking believe me there's the edit history to prove it.
I'm not even a rude person, but you drive me to this point with your pedantic obsessive bullshit which makes developing for MAME less of a fun task, and more one that damages my mental health so much it makes me want to find the nearest bridge to jump off.
This is a very simple PR full of very simple additions, it should not be a chore.
EVERYTHING was correctly credited before RB asked me to change it. EVERYTHING was clear and if you don't fucking believe me there's the edit history to prove it.
GitHub does not show edit history for comments or pull request descriptions. We get a notification when a pull request is opened or a comment is added. We do not get notifications when a pull request description or comment is edited.
The audit log shows the times when comments were edited. However it doesn’t show the content before/after the edit.
The only edits where content before/after is visible are edits to pull request and issue titles.
There is no way I can see the description of the pull request at the time you claim it had proper credits. Since it wasn’t there when you opened the pull request, it isn’t in the initial notification e-mail. There is no user-visible edit history.
Oh never mind, I found it. It’s hidden behind JavaScript on the page itself.
So now you've stolen the Software List parts of this, when it would have been easier to just merge the whole thing, what happens to the rest of it? Why is this simple case of adding some sets now such a nightmare?
Why is there so much needless bureaucracy here?
Who benefits from this?
You know, it would have been a lot easier if you’d just said, “all the cartridges were from me and TeamEurope” or something. You’re complaining about your workflow being interfered with, but at the same time going out of your way to make it difficult for everyone else.
I literally added the correct credits, and have been messed around. You're pulling apart simple PRs, needlessly. My mood would be better if you weren't making MAME such a fucking nightmare to work for.
Even now, rather than just merge the PR, you've forced me to deal with merge conflicts to get this PR mergable again. Added extra steps that don't need to be there.
This is just for the simple stuff. I've already retired from trying to make any actual progress in MAME, or cleaning anything up anywhere in MAME because of this. You're pushing to the point where I won't even bother trying to verify any of the new dumps either.
and personally I'd consider blanking / ghosting me just because I didn't agree with your suggested changed before for over a month to be equally as rude as anything I've said. I've reverted those changes now because I'd only made them to make sure the ROMs were good in the first place (which I thought had value, but I guess I should have made less effort)
if you're not going to give developers the freedom to develop, then development will not happen. Micromanaging everything is not the way forward.
apparently you've done the same to that Sonic proto, just ghosted the PR, because you don't want to merge it.
absolutely shit project management.
So now you've stolen the Software List parts of this, when it would have been easier to just merge the whole thing, what happens to the rest of it? Why is this simple case of adding some sets now such a nightmare?
I “stole” the software list parts because I fixed the titles, added track lists for user cartrdiges, fixed the now-outdated comment about undumped main series e-kara cartridges, etc. I also separated working and non-working items in the commit message so I don’t have discrepancies to resolve there when sorting out the release notes.
You weren’t going to fix the titles or add track lists yourself. You don’t read Japanese, as you’re always so quick to remind us. If I provided you with the details in review comments to add to your branch, you’d just complain that it’s inconvenient for you.
If I edited the files on your PR branch, it would add to the the already-convoluted commit history, and it would still be mixed up with the other unrelated stuff.
No matter what I do you’re going to complain. At least this way the software list items go in cleanly, and it’s an software list-only change that doesn’t need to trigger macOS and Windows CI builds.
apparently you've done the same to that Sonic proto, just ghosted the PR, because you don't want to merge it.
No, it’s another case of a person mixing unrelated things together, and repeatedly adding to it. Every time I go to try and salvage non-contentious parts from it, I find it’s changed again.
You seem to have this idea that if I haven’t actively commented on something in the last few days I’ve forgotten about it. That isn’t true.
The prototype isn't contentious.
Holding a personal grudge at the expense of preserving something, just because you don't like that it was hacked (and you won't be seeing an unhacked copy) is a critical failure of MAME's neutrality.
If you ignore a PR for near enough a year, yes, it will likely grow as related items are discovered and pushed, as you've created a bottleneck, broken somebody's workflow, and left things in a state where there will be merge conflicts that need to be fixed over and over again. This makes MAME look absolutely awful.
The fact that you brought up the same issue again with this PR when reminded about it, even if I said I preferred to not make the changes requested (thus ignoring developer preference) tells me you're going to just treat that one the same way, and will try and pull it apart still ignoring the Sonic addition, because you're that petty.
No, it’s another case of a person mixing unrelated things together, and repeatedly adding to it. Every time I go to try and salvage non-contentious parts from it, I find it’s changed again.
Of course a softlist PR will get new changes after months of not being merged. Entries will keep getting added to it and additional fixes will be made.
