rattler icon indicating copy to clipboard operation
rattler copied to clipboard

feat: refactor archive type

Open nichmor opened this issue 1 year ago • 3 comments

Based on my previous PR, I thought about making Archive type a building block so that you could reuse where needed.

This is how you would use it in rattler-build: https://github.com/prefix-dev/rattler-build/pull/922

nichmor avatar Jun 11 '24 15:06 nichmor

I like it! Maybe we can rename it LocalArchive to indicate that its a file on disk. There is also a lot of //test in the code. Could you clean this up? And add a few tests?

baszalmstra avatar Jun 11 '24 15:06 baszalmstra

I like it! Maybe we can rename it LocalArchive to indicate that its a file on disk. There is also a lot of //test in the code. Could you clean this up? And add a few tests?

sure! I've added //test to show how the refactor would look like and to see if the refactor is appropriate one

nichmor avatar Jun 11 '24 15:06 nichmor

I like it! Maybe we can rename it LocalArchive to indicate that its a file on disk. There is also a lot of //test in the code. Could you clean this up? And add a few tests?

done!

nichmor avatar Jun 12 '24 14:06 nichmor

Could you take another look at this PR when you have time @nichmor ?

baszalmstra avatar Nov 30 '24 10:11 baszalmstra

Could you take another look at this PR when you have time @nichmor ?

sure!

nichmor avatar Nov 30 '24 10:11 nichmor

This PR has been open for a couple of months. Would you mind closing the PR and reopening when you get the time?

baszalmstra avatar Feb 06 '25 09:02 baszalmstra

closing as it's not in the focus right now

nichmor avatar Feb 06 '25 12:02 nichmor