rattler
rattler copied to clipboard
feat: refactor archive type
Based on my previous PR, I thought about making Archive type a building block so that you could reuse where needed.
This is how you would use it in rattler-build: https://github.com/prefix-dev/rattler-build/pull/922
I like it! Maybe we can rename it LocalArchive to indicate that its a file on disk. There is also a lot of //test in the code. Could you clean this up? And add a few tests?
I like it! Maybe we can rename it
LocalArchiveto indicate that its a file on disk. There is also a lot of//testin the code. Could you clean this up? And add a few tests?
sure! I've added //test to show how the refactor would look like and to see if the refactor is appropriate one
I like it! Maybe we can rename it
LocalArchiveto indicate that its a file on disk. There is also a lot of//testin the code. Could you clean this up? And add a few tests?
done!
Could you take another look at this PR when you have time @nichmor ?
Could you take another look at this PR when you have time @nichmor ?
sure!
This PR has been open for a couple of months. Would you mind closing the PR and reopening when you get the time?
closing as it's not in the focus right now