rattler icon indicating copy to clipboard operation
rattler copied to clipboard

Channel in `RepoDataRecord` is a simple String

Open wolfv opened this issue 2 years ago • 3 comments

Should we either create a Channel type that we can use in RepoDataRecord and store it or a smart pointer to a shared / cached channel? Or should we type it as an URL?

It would be nice to be able to call a .url() and .name() method on the channel to get the short or expanded versions.

wolfv avatar Apr 02 '23 05:04 wolfv

I think this issue needs to be updated, there is a Channel type but RepoDataRecord still uses a string.

tarunps avatar Jul 31 '23 12:07 tarunps

The type also recently changed to an Arc<str>. I guess we could also change this to an Arc<Channel>?

baszalmstra avatar Jul 31 '23 17:07 baszalmstra

That'd make sense.

tarunps avatar Aug 01 '23 16:08 tarunps