rattler icon indicating copy to clipboard operation
rattler copied to clipboard

Published 20 hours ago • verified publisher icon mamba-org

feat: add support for layered package cache

Open kelvinou01 opened this issue 11 months ago • 10 comments

Description

Resolves https://github.com/conda/rattler/issues/43

Stuff to note

  • I tried to make this not a break, but alas. Specifically, i made PackageCacheError a #[non_exhaustive] enum, and modified some variants.

Old PR for ref

kelvinou01 avatar Dec 23 '24 11:12 kelvinou01

Hi @kelvinou01 - I also started hacking on this a bit but it looks like you are already much further progressed :)

Here was my attempt: https://github.com/conda/rattler/pull/998

wolfv avatar Dec 23 '24 11:12 wolfv

@kelvinou01 is this pr ready?

gzm55 avatar Feb 07 '25 01:02 gzm55

it seems the pr does not contains the changes of the config key.

gzm55 avatar Feb 15 '25 12:02 gzm55

@kelvinou01 is this pr ready?

@gzm55 not yet, is there an urgent need for it?

kelvinou01 avatar Mar 05 '25 09:03 kelvinou01

no urgent need. but expect this feature for multi-user environment

gzm55 avatar Mar 05 '25 09:03 gzm55

@wolfv hey, could you help me review this?

Also, I did try implementing storing the capabilities cache like #998. However, I thought this PR was large enough already, so the capabilities cache can be introduced in a subsequent PR.

kelvinou01 avatar Mar 08 '25 11:03 kelvinou01

when select a read or write cache, can we prefer the one from which we can make a hard link?

gzm55 avatar Mar 09 '25 01:03 gzm55

@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above?

kelvinou01 avatar Mar 09 '25 05:03 kelvinou01

@gzm55 I see how that can be useful! Do you think this feature is necessary to introduce with this PR, or can we do it in a subsequent one as i mentioned above?

I think a subsequent pr for the feature mentioned above is ok.

gzm55 avatar Mar 09 '25 07:03 gzm55

@baszalmstra is there other suggestions about this pr?

gzm55 avatar Apr 08 '25 10:04 gzm55

Would you be able to fix the merge conflict

@baszalmstra done!

kelvinou01 avatar Jul 29 '25 10:07 kelvinou01

@wolfv Would you be able to take a look at this PR?

baszalmstra avatar Aug 18 '25 20:08 baszalmstra

Is there anything left blocking this PR?

chrisburr avatar Oct 24 '25 13:10 chrisburr

I actually could use this feature well in rattler-build for temporary package caches during testing - so I'll fix the conflicts and merge it!

wolfv avatar Oct 25 '25 09:10 wolfv

Thank you @kelvinou01 and sorry for the extremely long wait!

wolfv avatar Oct 25 '25 11:10 wolfv

No worries at all. Happy to contribute!

kelvinou01 avatar Oct 26 '25 19:10 kelvinou01