mamba icon indicating copy to clipboard operation
mamba copied to clipboard

ci: test on macOS 15 (Intel)

Open henryiii opened this issue 1 year ago • 8 comments

macOS 13 is a target for homebrew, and still an important target for GHA, as it's the last Intel build they provide. I think on macOS 13 there will be a missing deduction guide error, but will have to see.

FYI, mamba-org/setup-micromamba@v2 is broken, probably see #3576.

(Likewise, I don't think GCC 11 is supported, only 13+)

Versions don't match, this is reporting Clang 17, while the homebrew job is using AppleClang 15.

henryiii avatar Nov 06 '24 17:11 henryiii

Thank you for this contribution, @henryiii.

Someone with a machine on macOS 13 should dive into this problem.

Note that we are only maintaining the distributions of mamba and micromamba on conda-forge, but we aren't against someone maintaining the distributions on Homebrew and upstreaming patches so that mamba and micromamba are portable or more systems.

jjerphan avatar Nov 18 '24 15:11 jjerphan

Any suggestions or thoughts on https://github.com/mamba-org/mamba/issues/3495 ? The problem is that the GHA runs here use the latest LLVM compilers, and not the AppleClang compilers that come with macOS, and systems like homebrew use the AppleClang compilers. I think there are a couple of uses of C++ features that aren't supported by the older compilers. So far it looks pretty easily fixable, I think? Maybe just adding some explicit types instead of using the deduction guidelines.

There's also a linux issue there.

henryiii avatar Nov 18 '24 15:11 henryiii

So far it looks pretty easily fixable, I think? Maybe just adding some explicit types instead of using the deduction guidelines.

Yes, definitely.

New GHA workflows can be set to test Homebrew's toolchains.

jjerphan avatar Nov 18 '24 17:11 jjerphan

Codecov Report

:white_check_mark: All modified and coverable lines are covered by tests. :white_check_mark: Project coverage is 63.62%. Comparing base (fe1fc2c) to head (065ea8a). :warning: Report is 76 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3578   +/-   ##
=======================================
  Coverage   63.62%   63.62%           
=======================================
  Files         300      300           
  Lines       38159    38159           
  Branches     2834     2834           
=======================================
  Hits        24278    24278           
  Misses      13826    13826           
  Partials       55       55           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :snowflake: Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

codecov[bot] avatar Jun 05 '25 08:06 codecov[bot]

@henryiii: using macos-15 resolves the problem but it seems that homebrew's CI uses macos-13, macos-14 and macos-15.

Must it use macos-13 and macos-14? I.e. would you accept those changes?

jjerphan avatar Jun 06 '25 09:06 jjerphan

13 is special because it's Intel based. That's what was failing on brew. It's not the last OS to support Intel (I'm on an Intel machine mostly, and am using the latest OS), but it was the last OS they provided with Intel runners (last I checked).

I expect macOS-13 to fail, I want it to fail here, because the problem needs to be fixed. Using macOS-13 was supposed to expose the problem that needs fixing. :)

henryiii avatar Jun 08 '25 04:06 henryiii

We don't have a macos-13 machine to debug, so we will wait.

jjerphan avatar Jun 11 '25 12:06 jjerphan

Is Homebrew still using macos-13 which is being closing down or another similar configuration?

jjerphan avatar Nov 24 '25 11:11 jjerphan

Closing as macos-13 is being rolled out.

jjerphan avatar Jan 07 '26 14:01 jjerphan