markdownpedia icon indicating copy to clipboard operation
markdownpedia copied to clipboard

Dark Theme

Open mamamia5x opened this issue 4 years ago • 16 comments

Create a pretty sweet looking dark theme. Something that Wikipedia doesn't have.

mamamia5x avatar Jan 28 '21 23:01 mamamia5x

Hi ! Can i work on this issue ? :)

4rtmelly avatar Mar 01 '21 10:03 4rtmelly

Yeah sure thing.

mamamia5x avatar Mar 01 '21 20:03 mamamia5x

Hey ! I made dark theme and added some div "card" for the picture of each contributors. Let me know if you like it or if you prefer to keep the table look. (I used bootstrap idk if it's fine ?) screen

4rtmelly avatar Mar 06 '21 19:03 4rtmelly

It looks great. Bootstrap is fine. Could you add a button to turn on darkmode? Like a moon button next to the search bar.

mamamia5x avatar Mar 07 '21 22:03 mamamia5x

Yeah sure i'm working on it !

4rtmelly avatar Mar 08 '21 08:03 4rtmelly

screenDark searchNormal

I used JS for the button dark/light mode. I worked in the markdowpedia/site/html repository and added a css & js repository to organized it, then modify the index.html How am I adding my code to this project now ?

4rtmelly avatar Mar 08 '21 13:03 4rtmelly

Create a pull request with the following code, and then I'll add it to the site once I get it up and running once again.

mamamia5x avatar Mar 08 '21 13:03 mamamia5x

Hey @mamamia5x! I'd like to work on this issue! I don't see this feature yet on https://markdownpedia.tk/ Could you let me know if it's still active and needs to be worked on?

osBins avatar Jun 09 '21 16:06 osBins

Sure, do whatever you'd like.

mamamia5x avatar Jun 09 '21 18:06 mamamia5x

Hey so I followed README.md to run markdownpedia locally on my system, but for some reason it formats incorrectly. image The commands I ran were npm install npm run convert npm run serve

  1. I request you to let me know what I'm doing wrong, to get the site to load correctly.
  2. I opened https://status.markdownpedia.tk/ from README.md and it doesn't seem to be working for me. Can you confirm?

osBins avatar Jun 10 '21 06:06 osBins

You did everything right, I created a script that tries to get the formatting to be the local URL, but it doesn't work properly, which is what is happening on your part. I'm trying to change some scripts for a new update, but there are some issues, and I haven't gotten back to this one. You can get rid of lines 102-115 in the vital/template.html file, but it may kill the search function.

The site I used to check status for markdownpedia recently made it a premium feature, and I'm not sure if I want to get it, I'll figure something out. If you have anymore questions, feel free to ask.

mamamia5x avatar Jun 10 '21 12:06 mamamia5x

Great! Getting rid of lines 102-115 in vital/template.html worked. I've commented them for now. I'll uncomment them when I create a PR and it is ready to be merged.

osBins avatar Jun 11 '21 07:06 osBins

All right sounds good, thanks.

mamamia5x avatar Jun 12 '21 17:06 mamamia5x

Hey! Can I work on it?

ramantamang777 avatar Jan 12 '22 11:01 ramantamang777

Hi ! I am interested to contribute . can you assign me the issue ?

harshi606 avatar Jan 18 '22 02:01 harshi606

hey, can I work on this project

bilalshaikh292 avatar Aug 18 '22 11:08 bilalshaikh292