google-style-precommit-hook icon indicating copy to clipboard operation
google-style-precommit-hook copied to clipboard

Readme instructions are wrong - hash doesn't exist

Open berney opened this issue 2 years ago • 0 comments

The readme includes instructions:

repos:
- repo: https://github.com/maltzj/google-style-precommit-hook
  sha: b7e9e7fcba4a5aea463e72fe9964c14877bd8130
    hooks:
      - id: google-style-java

There is no hash b7e9e7fcba4a5aea463e72fe9964c14877bd8130 in this projects git history.

git fetch --all
git log --all | grep -i b7e9e7fcba4a5aea463e72fe9964c14877bd8130 --count
0

Also since pre-commit 1.7.0, it should be rev not sha.

It would be convenient to use tags for releases IMO, but SHAs have the benefit of being immutable. If they were correct.

berney avatar May 11 '22 10:05 berney