Malte Kliemann

Results 118 issues of Malte Kliemann

Select an account that has a positive amount of ZTG and then query `tokens.accounts(account)`. The result is ``` { free: 0 reserved: 0 frozen: 0 } ``` Instead, ZTG has...

p:low
t:bug

Currently, arithmetic errors in the swaps pallet are `DispatchError::Other`, and display unfavorably in polkadot-js (just says "Other"). These errors should probably be module errors instead, or be a whole different...

p:low
t:enhancement

Fixes #800. This PR consists of a storage migration only. That may seem confusing. The storage migration transforms the numbers used in scalar markets to fixed point numbers by multiplying...

s:review-needed

## General Notes Details found in [ZIP-1](https://hackmd.io/@1ypDLjlbQ_e2Gp_1EW7kkg/BksyTQc-o). The implementation of the bisection method is roughly based on the implementation in [boost](https://github.com/boostorg/math/blob/develop/include/boost/math/tools/roots.hpp), which is licensed under the Boost License 1.0, which...

s:review-needed

Pretty much immediately after launch it seemed to me that we need more flexibility for scalar markets. If you bet on the change of some value in percentage ("How much...

p:medium
t:enhancement
l:M

When on-chain arbitrage is removed in favor of a fixed market maker, we need to remove the improvised solution for accessing the prize pool from `swaps`.

t:maintenance
l:S

In some situations, we require direct access to the `Balances` pallet instead of going through `MultiCurrency`. Using imbalances would be one example. We're currently using `CurrencyOf`, which "imports" the `Balances`...

p:low
t:enhancement
l:M

We need to replace ```rust #[pallet::weight(T::WeightInfo::swap_exact_amount_in_cpmm())] ``` with ```rust #[pallet::weight(T::WeightInfo::swap_exact_amount_in_cpmm().max(T::WeightInfo::swap_exact_amount_in_rikiddo(T::MaxAssets::get())))] ```

t:maintenance

The citation of Acala got gobbled up during a merge. Also, I discovered some code in `node/` that came from Polkadot (`ExecuteWithClient`).

p:low
s:review-needed

Calling `admin_clean_up_pool` calls `Swaps::clean_up_pool`, which calls `distribute_share_rewards` if the market is a categorical Rikiddo market. This function is not properly benchmarked and most likely subject to change when we rework...

p:low
t:bug