Malte Kliemann

Some more points: - We also need to be able to change assets (for example, someone might forget to provide a catch-all asset). The best way to approach this is...

I propose the following solution: The `dispute` method of `DisputeApi` may error with `DisputeInProgress` if a dispute has already been registered, but hasn't been handled by the dispute mechanism. For...

Another problem uncovered in recent meetings: When using `authorized`, people can call `dispute` even after the authority has submitted a report. I think the correct solution is to make appeals...

This is not a complete review, just a few general remarks. We should probably discuss there in an extra meeting: - You implement the `DisputeApi` for `global-disputes`. That's fine by...

Note that removing an item from the `MarketStatus` enum will require a storage migration. This is what the [substrate docs](https://docs.substrate.io/reference/scale-codec/) say about the encoding of enums: > A fixed number...

Yeah, sounds good. Do you see any problem with letting the crowdfunding run past market open? My thinking is: The market creator decides to crowdfund the pool. There's no harm...

Another example: The `Market` struct contains a `MarketDisputeMechanism`, which is an enum, but each member of the enum basically refers to one implementation of `DisputeApi`. When that implementation is to...

Starting my review now...

The user should be able to specify weights. This is important if they believe one outcome to be much more likely or unlikely than another. My solution would be to...

Hey @Chralt98. I didn't realize this issue still existed. This is basically solved in #672 by allowing the user to set the weights of the outcome tokens (since this allows...