discord-screenaudio
discord-screenaudio copied to clipboard
maltejur
Distributions and Environments integration
I might implement a different notification system, setting it optional. I will tell when the repository is ready to merge.
I might implement a different notification system, setting it optional. I will tell when the repository is ready to merge.
What do you mean exactly? There are already two ways for a noticiation to show, why a third?
Or are you talking about automatically detecting if kf5notifications is available? I have that already implemented on [this branch](https://github.com/maltejur/discord-screenaudio/tree/keybinds], but there are also some other changes there which arent ready yet.
What do you mean exactly? There are already two ways for a noticiation to show, why a third?
I mean, it's so small. Changing the font size would help my eyes haha
Also thought about using notify-send through the system, but would have to fetch the name, icon, and the text... maybe just making the current Qt notification better readable.
Wait, so the standard qt notification isn't a normal system notification for you? Interesting, I am on KDE so it is completely integrated there.
Wait, so the standard qt notification isn't a normal system notification for you? Interesting, I am on KDE so it is completely integrated there.
No. The standard notification here is notification-daemon. Without it, I won't receive any notifications at all.
One thing that I couldn't make is to show the icon. Do you have any idea @maltejur ?
I am currently not home so sorry for not working on your pull request so far. I am back in a week.
No problem. There are few touches here and there that I need to make it look acceptable.
One thing that I couldn't make is to show the icon. Do you have any idea @maltejur ?
This works for me:
notify-send --icon de.shorsh.discord-screenaudio Hello
One thing that I couldn't make is to show the icon. Do you have any idea @maltejur ?
This works for me:
notify-send --icon de.shorsh.discord-screenaudio Hello
I mean, for the users' images. I made it by saving the image to /tmp folder. This one can apply by the installation process.
Review the code, if you find any errors or changes you want to make. I have tried to do a "Reply" button. Successfully could make it interact with the application, but it opened another one for some reason.
I mean, for the users' images. I made it by saving the image to /tmp folder. This one can apply by the installation process.
Oh yeah I see you already solved it. But I am having a few problems with it, one of those errors always occurs when a notification should be shown:
However when I add a qDebug() << command; in there, just for checking the command, it works just fine again. Some weird C++ thing is going on here.
I think it would be best if you would just rewrite that code using Qt stuff, to fix the error and to generally make the code more consistent.
Some weird C++ thing is going on here.
Maybe because I used a function in C to return a "safe" message value back to the command. I tried doing the filter in C++, but it didn't let me.
I can guess what it could be. Some notifications don't show up sometimes, maybe because of the string getting a value out of memory or weird value return.
I think it would be best if you would just rewrite that code using Qt stuff, to fix the error and to generally make the code more consistent.
See https://github.com/KanuX-14/discord-screenaudio/pull/1
Regarding the notification system: distributions like Pop_os don't use libnotify but use the standard systemd-notify to deliver notifications, keep that in mind :)
distributions like Pop_os don't use libnotify but use the standard systemd-notify to deliver notifications
Thank you about this fact. I personally don't use Pop!_OS. If you know a way to implement it, feel free to push.
I will look into this in this week or so. This doesn't only apply to Pop, there are many distributions using systemd-notify, ofc