cycle2 icon indicating copy to clipboard operation
cycle2 copied to clipboard

latest jQuery

Open anton100 opened this issue 7 years ago • 6 comments

Cycle2 behaves erratic with jQuery 3.xx. Downgrading to jQuery 1.12 solves the problem. Is there a fix for using the newest jQuery? Anton

anton100 avatar Oct 10 '17 09:10 anton100

Seconded. I'm getting this error sporadically, every other time I load the page:

TypeError: a.indexOf is not a function

My site has a slideshow that takes up most of the page, so the animation improvements in jQuery 3 would be helpful to have.

zakgreene avatar Oct 31 '17 14:10 zakgreene

I did some searching and realized it was a very easy fix, so I forked the repo and fixed it. In jQuery 3, .load is removed and needs to be changed to .on('load')

Download here: https://github.com/zakgreene/cycle2/raw/master/build/jquery.cycle2.min.js

zakgreene avatar Oct 31 '17 16:10 zakgreene

Great Zak, i'm gonna try it.

anton100 avatar Oct 31 '17 16:10 anton100

Tried the fix with jQuery 3, the 'destroy' and 'reinit' is not working properly. With jQuery 1.12 it's working fine. It's the only function on the page, so why bother...

anton100 avatar Nov 09 '17 11:11 anton100

My security folks won't let me continue to work under an older jquery version, want us to update all to 3.1.4. So I really need a fix for this.

lorikay4 avatar Jan 09 '20 17:01 lorikay4

I have a fork here where I've updated several spots to deal with newer jQuery versions - if needed, test and report there - maybe I can help if problem not already resolved.

iam-sysop avatar Feb 15 '20 15:02 iam-sysop