cycle2 icon indicating copy to clipboard operation
cycle2 copied to clipboard

Fix for jQuery 3.0 load() deprecation. Fixes #778

Open jakeparis opened this issue 8 years ago • 9 comments

jQuery 3.0 has deprecated the load function. In this case, we wanted to check for something on the load event anyway, so we switch to using .on('load')

jakeparis avatar Jun 23 '16 20:06 jakeparis

LGTM ... in the meantime you should be able to use jQuery Migrate 3.0 to get the current version running again.

dmethvin avatar Jun 24 '16 13:06 dmethvin

Thanks for your fix. I can confirm this resolves the issue with the latest version of jQuery. I notice that no changes seem to have been committed for over two years so am wondering if this project is still active?

robinwilson16 avatar Oct 29 '16 12:10 robinwilson16

I think the project is dead.

ghost avatar Nov 08 '16 09:11 ghost

Yes, but it still works well.

jakeparis avatar Nov 09 '16 13:11 jakeparis

@jakeparis yeap, we use it too. But, I think the author should give other persons write access to maintain the project if he can't.

ghost avatar Nov 09 '16 14:11 ghost

It's a shame as Cycle2 is a really nice plugin

robinwilson16 avatar Nov 12 '16 21:11 robinwilson16

@malsup are you alive?

ghost avatar Nov 14 '16 12:11 ghost

thanks for this fix. after it cycle2 worked with my jquery v3.2.1.

tmuka avatar Sep 14 '17 15:09 tmuka

Thank you so much for the fix. That fixed one of my slide shows, but I also use the carousel feature with Cycle2 and that has an additional jquery file. This feature doesn't seem to work with jquery 3.0.

Is there any way to tell what might need to be updated to get the carousel to work with Jquery 3.0?

FisherFast avatar Jun 11 '18 15:06 FisherFast