cycle icon indicating copy to clipboard operation
cycle copied to clipboard

cyclePause might become -1, which reverses "pause on hover"

Open blueyed opened this issue 12 years ago • 3 comments

Under certain circumstances cyclePause might become negative and then the check ! cyclePause considers it not being paused.

In my use case, I am pausing the cycle plugin (cycle("pause")), when a video is being played in the slider. This interferes with the pause option to pause/resume on mouseenter/mouseleave. This is why I bind the same events on all child elements, and stop propagation of the event to the upper cycle container:

$('#slides-wrapper *').bind('mouseenter.cycle mouseleave.cycle', function(e) {
    e.stopPropagation();
    return false;
});

I am proposing a fix for this (also mentioned in issue #44).

I am not sure, if cyclePause needs to be something else than 0/1 to make the "pause on hover" work properly. If so, this should get documented in the code and another fix needs to be made for this.

blueyed avatar Sep 04 '13 13:09 blueyed

Are you using the latest code?

malsup avatar Sep 04 '13 13:09 malsup

Yes.

blueyed avatar Sep 11 '13 15:09 blueyed

I just noticed that my patch will cause the plugin to resume on mouseenter/-leave, if "pause on hover" is being used, after the "pause" action has been called manually. In this case mouseenter/-leave should not resume it.

blueyed avatar Sep 25 '13 10:09 blueyed