Xavier MALPARTY

Results 26 issues of Xavier MALPARTY

- Close #191 ## What happened 👀 Add the DATABASE_URL variable in the docker-assets-precompile script ## Insight 📝 All insights are discussed in the issue (#191) All credits to Hoang...

type : improvement

- Close #352 ## What happened 👀 - Remove the deprecated desired_capabilities from the capybara config ## Insight 📝 The `desired_capabilities` was deprecated quite some time ago and ended up...

type : bug

## Issue The env variable `PORT` is not set in the workflow which results in falling back on the `.env` file. This is a problem if we want to remove...

type : bug

## Issue Capybara deprecated the `desired_capabilities` option that we use in the file `spec/support/capybara.rb` to create a new instance `Capybara::Selenium::Driver.new`. ## Expected Running system tests should work out of the...

type : bug

- Close #365 ## What happened 👀 - Remove the custom config dependencies - Add the Nimble Stylelint config dependency for Web Variant - Use the Nimble config in the...

type : chore

- Close #362 ## What happened 👀 Add 2 Rubocop rules to allow 10 expectations per spec and 5 nested blocks. ## Insight 📝 `n/a` ## Proof Of Work 📹...

type : bug

## Issue Our conventions require us to use `bang!` methods that do not have safe equivalent. But our Danger code review bot will raise a warning each time: ## Expected...

type : bug

## Issue While our conventions preffer single-expectation tests, it is also clear that some integration tests should use multiple expectations in order to maintain good performances. ## Expected Rubocop should...

type : bug

- Close #363 ## What happened 👀 Just disabled that check :) ## Insight 📝 `n/a` ## Proof Of Work 📹 Tested in our internal projects, we do not have...

type : bug

## Why Currently we are using the following stylelint configs: ``` "stylelint-config-sass-guidelines", "stylelint-config-property-sort-order-smacss" ``` But now that we have a generic `@nimblehq/stylelint-config-nimble` package, we should use this one instead. ##...

type : feature