romcollectionbrowser
romcollectionbrowser copied to clipboard
Android bugs
findEmulators is called incorrectly. dialogeditromcollection:
autoconfig.findEmulators(util.current_os, self.selectedRomCollection.name, True)
wizardconfigxml:
autoconfig.findEmulators(util.current_os, romCollection.name, True)
util.current_os is a function so should be
util.current_os()
launcher.py
def __getEncoding(self):
# HACK: sys.getfilesystemencoding() is not supported on all systems (e.g. Android)
try:
encoding = sys.getfilesystemencoding()
except Exception:
log.warn("Unable to get filesystem encoding, defaulting to UTF-8")
encoding = 'utf-8'
return encoding
i trully believe it should be
def __getEncoding(self):
# HACK: sys.getfilesystemencoding() is not supported on all systems (e.g. Android)
encoding = 'utf-8'
try:
encoding = sys.getfilesystemencoding()
except Exception:
log.warn("Unable to get filesystem encoding, defaulting to UTF-8")
return encoding
Thanks for the hints. The autoconfig is somehow fixed in the branch https://github.com/maloep/romcollectionbrowser/tree/autoconfig. I just did not manage to finally test and merge these changes. And it still has some quirks.
The __getEncoding part was reported to be working on Android. I can't test it myself as I do not have a working Android device that is able to run Kodi. But you are right, your version is the better implementation.