ROMs as folders is no longer working

[GoogleCodeExporter]

What steps will reproduce the problem?
1. Open Higan or Bsnes and import SNES or NES games into it's library

2. Point new ROM collection to the folder where Higan/Bsnes placed all the 
games. Each game is in it's own folder called "gamename.sfc" (or "gamename.fc" 
for NES titles). These folder names are what need to be passed as a parameter 
to Higan in order for it to launch the game.

3. Add SNES or NES rom collection to RCB and point it to the folder. Add *.sfc 
or *.fc as the ROM file mask.

What is the expected output? What do you see instead?
RCB used to see the .sfc and .fc folders with the appropriate file masks, but 
now the only way to get it to see the games at all is to turn on "use folder 
name as game name" and change the mask to just "*". Doing this gets RCB to 
scrape game information, but the %ROM% it is sending to Higan when you try to 
launch a game is incorrect. Higan needs the folder itself passed in, not the 
.rom file inside it.

What version of the product are you using? On what operating system?
RCB 2.0.6, XBMC 12.1, Windows 8 64 bit.

Original issue reported on code.google.com by [email protected] on 23 Apr 2013 at 7:15

[GoogleCodeExporter]

Original comment by maloep on 12 Jul 2013 at 7:55

• Changed state: Accepted

[GoogleCodeExporter]

I created a patch that fixes this. It simply creates another Emulator Parameter 
(as described here, 
https://code.google.com/p/romcollectionbrowser/wiki/EditRomCollectionLaunchGames
#Emulator_Params) called %ROMDIR%, which contains the game's path up to the 
directory only. 

So with this patch you can change %ROM% to %ROMDIR% for every ROM collection 
that uses higan and it should work. I tested this with RCB 2.0.17 on XBMC 13.2 
with GB, NES and SNES ROMS from a higan v094 library.

Hopefully this can get included in the next version of RCB.

Original comment by [email protected] on 24 Aug 2014 at 1:35

Attachments:

• add_romdir_param.patch

[GoogleCodeExporter]

Many thanks for this! Works perfectly with SNES/NES using RCB 2.0.17/XBMC 
13.2/Ubuntu 14.04. Much appreciated!

Original comment by [email protected] on 17 Oct 2014 at 4:01

[GoogleCodeExporter]

Hey I'm very curious as to how this patch works in Ubuntu.  I can't seem to get 
it to work.  How do I go about applying the patch?

Any help would be greatly appreciated!

Thanks

Original comment by [email protected] on 28 Oct 2014 at 5:00

[GoogleCodeExporter]

If you're not familiar with how patches work, you can easily search for it on 
the internet. You might also consider reading the manpages of patch and diff 
(by running "man patch" and "man diff" in a terminal). In short, a patch file 
is just a text file that describes the exact differences between two files.

In this case, if you don't know about patch files, it's probably easier to just 
make the changes manually since the differences in my patch file are small and 
simple. To do this, you just open the patch file with a text editor. The 
additional lines of code are marked by a + character at the start of the line. 
You need to copy those lines (excluding the + character) to the 
"resources/lib/launcher.py" file of your installed romcollectionbrowser addon 
folder (found in ~/.xbmc/addons/script.games.rom.collection.browser). Look at 
the surrounding text and the line number given in the patch file to find out 
the correct place to add the new lines.

If you do want to use the patch command to execute the patch file, remember 
that you'll need to run the patch command from the rommcollectionbrowser addon 
folder or provide the path to that folder with the -d parameter. Look at the 
manpage for more details on that. Hope it works for you and remember to make a 
backup of everything you might change.

Original comment by [email protected] on 13 Nov 2014 at 9:17