OctoPrint-FilamentManager icon indicating copy to clipboard operation
OctoPrint-FilamentManager copied to clipboard

Move filament database to tabs at top.

Open MStylesMS opened this issue 7 years ago ā€¢ 22 comments

Very nice plug-in! Thank you for creating it.

One feature request is to move the management of the spools to a tab at the top of the screen rather than it being hidden down in the settings.

MStylesMS avatar Jan 12 '18 06:01 MStylesMS

The main reason why the spools table locates in the settings is that there is more space. The width of the tab view on the main screen is significantly smaller. Sometimes there are requests for additional table columns which I have to decline because there is not enough space for that.

I'd also like to move this part to a tab view because it has nothing to do with settings. But as you see I cannot just move it as it is now. Maybe if I get an idea on how to redesign the spools table/management I'm moving this part.

malnvenshorn avatar Jan 12 '18 17:01 malnvenshorn

That makes sense and I've been pondering it a bit. The limited width is a limitation. ;-) So, thinking about this a bit more today had a thought I thought I'd throw over to you. (Sorry...in a punny mood tonight.)

One approach that came to mind was to take a hybrid approach that combines your current table with the file list approach in the left pane of OctoPrint. To me, the main three things to see are 1) Name, 2) Material, and 3) Remaining. The rest is interesting, but I don't need that as much. So here are the thoughts:

  1. I'd try to keep those as three columns similar to what you have now.
  2. I'd also keep the Action column but add in the down carrot (or maybe an information icon a "!" inside a circle). When you click on that then you could show all kinds of detail for the record.

I realize there others might want some other details shown where you could sort or scan down a column, but I'm not sure why most of those things would be that important.

MStylesMS avatar Jan 15 '18 04:01 MStylesMS

I think that @MStylesMS suggestion woould be a great compromise. Just to see the inventory information with the basic info and get a bird's view of your inventory would be great. I would very much like to see that in a tab at the top.

reven avatar Apr 11 '18 00:04 reven

I'm currently thinking about adding this request to the 0.6.0 milestone.

Here some idea how it might look like: 7tf1dse

I totally got rid of the total weight and used column, because I agree that they are not that important. But I consider to add some filter options, e.g. for the material type.

malnvenshorn avatar Apr 25 '18 12:04 malnvenshorn

That looks great! Can't wait. šŸ˜ƒ

reven avatar Apr 25 '18 19:04 reven

An update. As always your feedback is welcome :wink:

bildschirmfoto_2018-04-26_09-03-09

malnvenshorn avatar Apr 26 '18 07:04 malnvenshorn

If someone wants to try it out, this feature is now available on the feature/move-inventory-to-tab branch. ~~Everything except the filtering should work.~~

malnvenshorn avatar Apr 27 '18 09:04 malnvenshorn

Sven, this looks really great. I've tried duplicating and editing spools and everything seems to work. It's great to have all the info there as a tab and not have to go into the settings. I'll try printing a few things and see how it holds up. I'll let you know if anything breaks.

Thanks for the hard work!

reven avatar Apr 27 '18 18:04 reven

Iā€™m traveling but will give it a try next week. Thanks!!!

Mark Stevens

Sent from my iPhone All typos are Siri's fault!

On Apr 27, 2018, at 11:52 AM, Robert Sanchez <[email protected]mailto:[email protected]> wrote:

Sven, this looks really great. I've tried duplicating and editing spools and everything seems to work. It's great to have all the info there as a tab and not have to go into the settings. I'll try printing a few things and see how it holds up. I'll let you know if anything breaks.

Thanks for the hard work!

ā€” You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/malnvenshorn/OctoPrint-FilamentManager/issues/70#issuecomment-385061837, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ATsI7GC3Bum8jNIW6Ntmu-bv2zO9tb_qks5ts2jVgaJpZM4Rb2U9.

MStylesMS avatar Apr 27 '18 18:04 MStylesMS

@reven Thanks for your feedback and the praise. It's always nice to know that your own work gets acknowledged :smiley:

@MStylesMS That would be great. Thanks.

malnvenshorn avatar Apr 28 '18 08:04 malnvenshorn

I came across some issue. If you have a spool selected and apply a filter which doesn't include the selected spool the selection will be reset.

Two solutions come to my mind:

  1. I can make the selection independent from the inventory table. That means sorting and filtering will not be applied.
  2. If you think it would be cool to keep that dependency I have to make sure that the selected spools don't get removed from the selection (or even the inventory?). The question in this case is how do I highlight them to show that they are actually not part of the filtered entries.

Which solution would you prefer?

malnvenshorn avatar Apr 29 '18 16:04 malnvenshorn

@malnvenshorn what is selection in this case? Are you referring to clicking on the dropdown menu to the right of the spool, where having that open means the spool is "selected"? Or are we talking about selection in the more traditional sense, where you click on one or more items in the table to highlight them and later perform some action on the selection?

If it's the latter, let's see...

  • If you keep the selection visible in the table when the user changes the sorting or filtering options, they may wonder why some entries are not filtered out. As you've implied, this can be unintuitive without somehow clearly conveying to the user why this is happening.
  • If you clear the selection when the user changes the sorting or filtering options, this may be unexpected.

A third, more complex option would be to copy what Google does with (desktop) Gmail.

  • The selection is independent from the table, so changing the filter retains your selection "in the background".
  • The actions you perform (e.g. delete, archive) only affect the visible part of the selection, so only the emails that are:
    • selected
    • match the filter (if any)
    • visible on the current page

mickdekkers avatar Apr 30 '18 12:04 mickdekkers

I'm talking about the spool selection list in the sidebar. At the moment it uses the same data source as the inventory table which causes the described behavior.

malnvenshorn avatar Apr 30 '18 20:04 malnvenshorn

Oh, I see. I think it would be a good idea to keep that selection list simple. It's a quick way to pick from all your available spools, and I'm not sure whether filtering would add much value to it. So making it independent from the inventory table would probably be best.

Here's a thought: how about adding a button to the spools on the inventory table to activate them? This would still allow users to apply filtering and sorting to narrow the inventory table down to the spool they're looking for, and you can avoid the dependency issue between the selection list and the inventory table.

Here's a quick photoshop: edited screenshot of the inventory table showing an activate entry in the popout menu

mickdekkers avatar Apr 30 '18 21:04 mickdekkers

Thanks. This is a great idea!

malnvenshorn avatar May 01 '18 06:05 malnvenshorn

Few changes:

  • Page size will be restored on reload
  • Spools can also be selected from the inventory table
  • Sidebar selection is not affected by sorting and filtering of the inventory table

malnvenshorn avatar May 01 '18 15:05 malnvenshorn

Some last minor changes:

  • Disabling certain inventory actions if user is not logged in
  • Automatically apply filter if target column is changed
  • Reset button for inventory filter

I think that's it, unless someone stumbles across issue :wink:

Merged into develop.

malnvenshorn avatar May 03 '18 12:05 malnvenshorn

+1 Great work. Thank you.

szafran81 avatar Dec 31 '18 14:12 szafran81

I was just going to suggest this idea! Great to see it's already been done, any idea when it will go live?

a8bit avatar Oct 03 '19 14:10 a8bit

Love this plugin; so useful. This new tabs feature I was dissapointed to see was not live yet in the main branch...any idea when it will be included?

Silventar avatar Feb 13 '20 15:02 Silventar

I also looking for the TAB feature. It will be great if you develop it or launch. great plugin I like it

schuessm avatar May 05 '20 09:05 schuessm

How can I enable this TAB feature?

piotr-kubica avatar Aug 06 '23 20:08 piotr-kubica