a-file-icon-idea icon indicating copy to clipboard operation
a-file-icon-idea copied to clipboard

Improve color overriding

Open mallowigi opened this issue 1 year ago • 2 comments

Currently the color overriding option requires an attribute of either iconColor or iconFolderColor with the name of the association to work. This is very limited and make the feature only relevant for bundled associations.

We need to find out better options:

  • When calling loadIcon with an Association, apply a colorParser with the association's color, independently of the SVG file
  • Need to find a placeholder. We can't use fill because it can be found in many paths inside the svg. We can't also use the first child of type path because it's not necessarily the case for all svg icons. So we could consider the same iconColor or folderIconColor and replace the attribute fill inside the same node.

mallowigi avatar Aug 18 '23 12:08 mallowigi

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Sep 03 '23 12:09 stale[bot]

This PR has been automatically closed because it has not had recent activity. You can reopen it by clicking on Reopen pull request. Thank you for your contributions.

stale[bot] avatar Oct 04 '23 02:10 stale[bot]