a-file-icon-idea icon indicating copy to clipboard operation
a-file-icon-idea copied to clipboard

Add new icons set from Material Design 2/3 (Outlined, Dual tone, Round, ...)

Open maicol07 opened this issue 2 years ago • 6 comments

Is your feature request related to a problem? Please describe. While Material Theme UI has been revamped with Material Design 2, icons are still the same

Describe the solution you'd like New sets of icons that can be chosen with a setting

Describe alternatives you've considered None

maicol07 avatar Jun 01 '22 18:06 maicol07

Hmmmmmmmmmm while this is a good idea, this would bloat up the package a lot... besides outlined icons are not for all icons, aren't they?

Can you provide more information about what you're referring to?

mallowigi avatar Jun 01 '22 19:06 mallowigi

Yeah, some outlined icons don't exist. Simply that icon will fallback to the default Material one. I recommend materialdesignicons.com or Icons8 to look for icons since they got much more icons than the standard Google set.

I have two ideas to avoid to bloat up the plugin:

  1. Provide optional plugin to add more icons variant (although I don't know if it's possible to get plugins interact each other)
  2. Allow users to add icon sets to a specific folder(s) and allow users to switch the icons through a setting.

It would be great if standard icon sets (outlined, filled, round, sharp, dual tone, ...) can be provided with the plugin release (i.e. from Github releases)

maicol07 avatar Jun 02 '22 21:06 maicol07

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jun 17 '22 09:06 stale[bot]

@mallowigi what do yout think?

maicol07 avatar Jun 25 '22 08:06 maicol07

This will have to wait. Currently we have a big hurdle is that there is no way to control the PSI and UI Icons. These are replaced using the concept of "patchers", but they are on a "per-plugin level" (e.g. replace the path) rather than on a "per icon level" (replace the icon).

One big refactor that I'll have to do at some point would be to add both. This would allow both custom associations and whatever you are recommending.

But this will happen way, way later. (That is unless you want to dirty your hands :))

mallowigi avatar Jun 25 '22 09:06 mallowigi

This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Jul 09 '22 10:07 stale[bot]