EmbedKGQA icon indicating copy to clipboard operation
EmbedKGQA copied to clipboard

Relation Matching for MetaQA

Open XLR81999 opened this issue 3 years ago • 6 comments

Hi, I've been following this approach for a while, I've noticed that Relation Matching module has been added, however I couldn't find it for MetaQA/LSTM approach, will it be added later or is it not yet implemented?

XLR81999 avatar Mar 25 '21 06:03 XLR81999

Hi, I will try too add ASAP

apoorvumang avatar Mar 25 '21 14:03 apoorvumang

Hi, in the paper you mentioned that relation matching was performed for the larger dataset to boost its performance and typically for relatively smaller KGs like MetaQA the answer is selected based on the highest score. Using only the highest score, it is not possible to achieve the reported results for MetaQA, as mentioned in #31 the best result for 3-hop questions is around 70. Did you use relation matching also for MetaQA/LSTM? If yes, it will be highly appreciated if you upload the code. Thank you.

namadjidku avatar Apr 15 '21 05:04 namadjidku

@namadjidku Relation matching was needed for only 3-hop full setting in MetaQA since the paths are too long for the base model to handle properly. For 3-hop half, relation matching was not used (since it doesn't work well on incomplete graphs).

The code requires a bit of cleaning up before upload. Will be uploading it ASAP.

apoorvumang avatar Apr 15 '21 05:04 apoorvumang

Hello, is there any updates for relation matching, to generate 3-hop model as state-of-the-art classifier.

okanvk avatar May 13 '21 23:05 okanvk

Hi, is there any updates for Relation Matching code?

okanvk avatar Mar 09 '22 22:03 okanvk

Not yet unfortunately. I will pin this issue until it gets added. However, based on more recent work in this area/MetaQA dataset, I would recommend against using EmbedKGQA in full KG setting - semantic parsing models should be used in such a setting IMO.

If needed, you can use the 0.728 number mentioned in #31 for reporting.

apoorvumang avatar Mar 09 '22 23:03 apoorvumang