rocketchat-gitlab-hook icon indicating copy to clipboard operation
rocketchat-gitlab-hook copied to clipboard

Published 20 hours ago • verified publisher icon malko

Avatar of private projects not displayed correctly.

Open SevenOutman opened this issue 5 years ago • 1 comments

I've run into this problem that when the webhook post a message for a push event, its avatar was missing. I inspected the DOM and found that the avatar image url was the avatar for that project/repository. Since the repository was private, requests for its url (especially sent from rocket client) were blocked and redirected to the signin page. I guess the script should avoid using project's avatar when it's not public accessible.

SevenOutman avatar Aug 22 '19 08:08 SevenOutman

Yes would be fine, can you please make amerge request ?

malko avatar Oct 02 '19 18:10 malko

no more activity on this closing.

malko avatar Feb 24 '23 11:02 malko