mali icon indicating copy to clipboard operation
mali copied to clipboard

Implement Reflection

Open stephen-dahl opened this issue 5 years ago • 6 comments

Hi, good work with this so far!

Mali should support reflection once it is implemented in the core lib https://github.com/grpc/grpc/blob/master/doc/server-reflection.md https://github.com/grpc/grpc/issues/2568

Or sooner if you dont need them :)

stephen-dahl avatar Oct 19 '18 15:10 stephen-dahl

Yes this would be useful, and will implement once it's in the core grpc library.

bojand avatar Oct 20 '18 00:10 bojand

Has this been implemented yet ? @bojand

kashifmin avatar Mar 21 '19 06:03 kashifmin

Hello, thank you for inquiring about this issue. This is not implemented yet as the core grpc Node.js module does not support reflection yet.

bojand avatar Mar 21 '19 11:03 bojand

Does core actually need to support it first? Python and C++ have reflection as separate packages, and AIUI the js structures created either by dynamic or static should already have all the metadata (descriptors) needed by reflection. The ticket in the core lib mentions it can be done as a separate library.

Bonus: that means Mali can probably also have it as an optional add-on mali-reflection, so you only get it if you specifically want it.

lalomartins avatar May 28 '19 14:05 lalomartins

Any there any new update on this issue?

ansarizafar avatar Nov 24 '19 03:11 ansarizafar

It seems that Reflection can be implemented without support in core grpc library https://github.com/grpc/grpc-node/issues/79#issuecomment-491699115

ansarizafar avatar Nov 24 '19 03:11 ansarizafar