crypto-hash icon indicating copy to clipboard operation
crypto-hash copied to clipboard

Add feature to vendor openssl

Open tshepang opened this issue 4 years ago • 3 comments

To help build more portable executables, it would be nice to have an option to build against a vendored openssl version.

At the moment, I have to do the following myself, even though openssl is a transitive dependency:

# This is a hack, to force openssl to be built statically.
# It's a dependency of crypto-hash.
[dependencies.openssl]
version = "0.10"
features = ["vendored"]

tshepang avatar Jun 06 '20 06:06 tshepang

Can you explain why this is a hack?

malept avatar Jun 06 '20 06:06 malept

Am controlling how a transitive dep is built, and that makes it look like I depend directly on it. Would be better if there was a cargo feature (in crypto-hash) to choose.

tshepang avatar Jun 06 '20 12:06 tshepang

I'm happy to take a pull request for this. Please make sure that it gets documented in the README, too.

malept avatar Jun 06 '20 15:06 malept