SwiftDate icon indicating copy to clipboard operation
SwiftDate copied to clipboard

Fix for an issue that caused WeekStartDay to fail while initializing Region

Open Vignesh-Thangamariappan opened this issue 3 years ago • 4 comments

Ref: https://github.com/malcommac/SwiftDate/issues/690

Vignesh-Thangamariappan avatar Sep 21 '21 09:09 Vignesh-Thangamariappan

@malcommac this seems like a valid fix for a valid bug. Can we merge it? @Vignesh-Thangamariappan can you rebase?

ExtremeMan avatar Nov 17 '22 22:11 ExtremeMan

Or return back this method? https://github.com/malcommac/SwiftDate/compare/4.5.1...5.0.0#diff-4ddb0e769834923d6d637cfe9c9974c5d6d2c0e17c1703ac9ec3b7eaae5f68a9L89-L96

	/// Identify the first weekday of the calendar.
	/// By default is `sunday`.
	public var firstWeekday: WeekDay {
		set {
			self.calendar.firstWeekday = newValue.rawValue
		}
		get {
			return WeekDay(rawValue: self.calendar.firstWeekday)!
		}
	}

ExtremeMan avatar Nov 17 '22 22:11 ExtremeMan

Sure @ExtremeMan I'm on it

Vignesh-Thangamariappan avatar Jan 13 '23 17:01 Vignesh-Thangamariappan

@malcommac Can you please review and merge these changes. Would be helpful for people facing #690

Vignesh-Thangamariappan avatar Jan 13 '23 17:01 Vignesh-Thangamariappan