lattice-estimator icon indicating copy to clipboard operation
lattice-estimator copied to clipboard

Comment difference rough vs estimate

Open GuilhemN opened this issue 1 year ago • 3 comments

Following a private email discussion with Martin and others, I would suggest adding a comment in the README about the main API and the cost models in use throughout the codebase.

I was quite confused that rough uses [ADPS16] by default, but the rest of the code rather relies on [MATZOV] for the concrete cost of lattice reduction.

GuilhemN avatar Aug 22 '24 23:08 GuilhemN

Thanks for your feedback! I updated the pull request to take it into account, I hope that's better now :)

GuilhemN avatar Aug 23 '24 18:08 GuilhemN

Great! A few CI failures to take care of but otherwise good to go. Thank you!

malb avatar Aug 23 '24 20:08 malb

Perfect! Should be good now

GuilhemN avatar Aug 24 '24 18:08 GuilhemN

Ta!

malb avatar Aug 25 '24 19:08 malb