320andup icon indicating copy to clipboard operation
320andup copied to clipboard

Published 20 hours ago • verified publisher icon malarkey

border-radius > rounded

Open deadlyhifi opened this issue 12 years ago • 4 comments

Again, I can't do a pull request because of my edits but in the SASS and SCSS and possibly some other flavours border-radius has been used where it should be rounded.

Namely any use of border-radius that has a single value in the brackets.

deadlyhifi avatar Aug 02 '12 10:08 deadlyhifi

I believe you are looking in the Compass versions, in which +rounded is not necessary because +border-radius already exists in Compass. :)

jina avatar Aug 02 '12 10:08 jina

I mean within the actual use of the mixins.

e.g. https://github.com/malarkey/320andup/blob/master/scss/_buttons.scss#L33 creates a top right 4px rounded corner where it should be on all corners.

This occurs on a few buttons, and also on the wells within _texture.scss.

deadlyhifi avatar Aug 02 '12 10:08 deadlyhifi

Hrm, okay I will look into that. When I noticed Andy was calling out a particular corner rather than all corners, I opted for Compass'es mixins instead of Andy's so it'd be less repetitive code. Perhaps I accidentally ported some of that over to the non-Compass files. Will fix once I get a chance to look at it. Thanks!

jina avatar Aug 02 '12 11:08 jina

Thats alright, thanks for doing all the porting in the first place.

deadlyhifi avatar Aug 02 '12 11:08 deadlyhifi