Missing clearfix

[deadlyhifi]

There is a missing .clearfix { @include clearfix; } in the following files.

SCSS: https://github.com/malarkey/320andup/blob/master/scss/_mixins.scss#L213 SASS: https://github.com/malarkey/320andup/blob/master/sass/_mixins.sass#L230 LESS: https://github.com/malarkey/320andup/blob/master/less/mixins.less#L214

I would have done a pull request but I've changed the rest of files quite significantly so it would all end up quite messy. I also can't fork a repo more than once. So I'm saying it here!

[jina]

For LESS, .clearfix { @include clearfix; } is not necessary because the .clearfix mixin already exists, which behaves as a class as well.

For the Sass files, I added that line as a convenience in the Compass versions of the files because in Sass, mixins do not equal classes, and I noticed Andy's templates use a clearfix class in the markup. I figured it'd be helpful, but it was not really necessary.

I can add those in the other Sass files, too, if it helps, but my preference would be to lose the class all together and rely on extended placeholder selectors. :)

[deadlyhifi]

I see. I only noticed it because if you swap the stylesheet within 320andup.html to <link rel="stylesheet" href="css/320andup-scss.css"> to use the compiled stylesheet the base colour list doesn't display properly. Adding the clearfix and recompiling fixed it.

https://github.com/malarkey/320andup/blob/master/320andup.html#L30

[jina]

Makes sense. I'll add them once I get a chance. Thanks! :-)