Broken images on web view

[markCwatson]

Many pages on the web view have broken images. For example, here https://maksimdrachov.github.io/zephyr-rtos-tutorial/docs/3-threads/introduction.html

[Bardoctorus]

While it hasn't been fixed, I think the reason for this can be found in Issue 11.

[markCwatson]

Ah yes, this is a duplicate issue it looks like

[maksimdrachov]

Sorry guys, I'm really busy with work; if someone submits a MR I promise to review it tho.

[Bardoctorus]

Don't sweat it, you've made a fantastic tutorial for free - I just noticed the same thing, noticed the duplicate issue and wanted to flag it. It's totally fine in on github and I've been following along that way.

At some point when I have a sec (I'm also completely slammed) I'll see if I can sort it and post it for review.

On Tue, Dec 12, 2023 at 2:07 PM maksimdrachov @.***> wrote:

Sorry guys, I'm really busy with work; if someone submits a MR I promise to review it tho.

— Reply to this email directly, view it on GitHub https://github.com/maksimdrachov/zephyr-rtos-tutorial/issues/17#issuecomment-1852001353, or unsubscribe https://github.com/notifications/unsubscribe-auth/AEGGVCHRGSHKC75XKRYDHOTYJBJHJAVCNFSM6AAAAAA6TCWZVOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQNJSGAYDCMZVGM . You are receiving this because you commented.Message ID: @.***>

[maarten1C96]

I think the image paths only need to two extra parent directory references. For example instead of /images/2-introduction/sample-folder.png, on my computer ../../images/2-introduction/sample-folder.png solves the problem.

(And very fantastic tutorial indeed!!!)

[maarten1C96]

I am willing to take over this issue, is @maksimdrachov still active on his repository? As described in the contribution guide:

"In comments claim that you want to take over the issue. The first person who does this will be assigned to the issue."

[maksimdrachov]

Yeah sure, go ahead!

[maarten1C96]

Yes, see pull request!