Maks Rafalko

Results 212 comments of Maks Rafalko
trafficstars

Hello @ancarda * are you talking about this feature? https://docs.gitlab.com/ee/ci/unit_test_reports.html#how-to-set-it-up * do you have an example repository where I can see how this format looks like on GitLab? I don't...

We are relying on [`ocramius/package-versions`](https://github.com/Ocramius/PackageVersions) package: https://github.com/infection/infection/blob/c2bd612a4c1ef1d8d303f2c1962eaf90a2adacc4/src/Console/Application.php#L83 ```bash composer install Loading composer repositories with package information Installing dependencies (including require-dev) from lock file Nothing to install or update Generating autoload...

Actually, there is a fallback right in the library: https://github.com/Ocramius/PackageVersions/blob/3a7ca6eafde0eec1b964cf967e6e71bf27ecc737/src/PackageVersions/FallbackVersions.php See https://github.com/Ocramius/PackageVersions/pull/33/files#diff-f9a41167d45cff28a9aefaefc0ba85e3R5-R12

I think we just need to update to the latest version and everything should work out of the box. Currently, we are on `1.4.0`, latest is `1.5.1`

> @maks-rafalko you cannot, package-versions `1.5.x` require PHP 7.3 Infection is using PHP 7.3 on `master`, can we fix this issue with upgrading `ocramius/package-versions`?

Is it still an issur @scaytrase ? We are using `ocramius/package-versions` 1.9.0 at the moment

Had to revert this change since it breaks Phar creation, see https://github.com/infection/infection/pull/1520

Please read the full explanation about why we don't support `@codeCoverageIgnore` on the line level here in the PR description https://github.com/infection/infection/pull/491 Why do you need it? What is the use...

> Strict type checking utilities force me to create a null check as such to get a passing build: If you are using PHPStan, you can add a [`phpstan-webmozart-assert`](https://github.com/phpstan/phpstan-webmozart-assert) plugin...

> ```php > // @codeCoverageIgnoreStart > if ($result === null) { > // following cannot be covered as we never actually get `null` (see catch block) > continue; > }...