blockparty icon indicating copy to clipboard operation
blockparty copied to clipboard

Ambiguous state: Participant.paid. Should be Participant.been_paid

Open vietlq opened this issue 6 years ago • 3 comments

Ambiguous state: Participant.paid. Should be Participant.refunded

https://github.com/makoto/blockparty/blob/master/contracts/Conference.sol#L26

    struct Participant {
        string participantName;
        address addr;
        bool attended;
        bool paid;
    }
        require(participant.paid == false);

        participant.paid = true;

vietlq avatar Jul 18 '18 10:07 vietlq

refund is true if the event is cancelled but users get deposit+extra so not sure refund is the correct term.

makoto avatar Jul 18 '18 10:07 makoto

paid can be understood 2 ways: the person paid or the person has been paid (which is used in this context).

So probably: paid => been_paid

vietlq avatar Jul 18 '18 10:07 vietlq

Yeah that's better. I am trying to keep interface change to minimum as it breaks the compatibilities with older contracts, but I will consider putting in when we introduce breaking changes.

makoto avatar Jul 18 '18 11:07 makoto