blockparty
blockparty copied to clipboard
Ambiguous state: Participant.paid. Should be Participant.been_paid
Ambiguous state: Participant.paid. Should be Participant.refunded
https://github.com/makoto/blockparty/blob/master/contracts/Conference.sol#L26
struct Participant {
string participantName;
address addr;
bool attended;
bool paid;
}
require(participant.paid == false);
participant.paid = true;
refund
is true if the event is cancelled but users get deposit+extra so not sure refund
is the correct term.
paid
can be understood 2 ways: the person paid or the person has been paid (which is used in this context).
So probably: paid
=> been_paid
Yeah that's better. I am trying to keep interface change to minimum as it breaks the compatibilities with older contracts, but I will consider putting in when we introduce breaking changes.