slack icon indicating copy to clipboard operation
slack copied to clipboard

App share was deprecated in laravel 5.4. Using app singleton.

Open whoacowboy opened this issue 8 years ago • 3 comments

You master was off from the tag so I made a new branch, laravel5.4.

I changed one line of code because app->share was deprecated in 5.4 for app->singleton.


share Method Removed

The share method has been removed from the container. This was a legacy method that has not been documented in several years. If you are using this method, you should begin using the singleton method instead:

$container->singleton('foo', function () {
    return 'foo';
});

whoacowboy avatar Feb 13 '17 18:02 whoacowboy

This should be a priority. The fix takes few seconds to implement, but is indeed breaking. I did the same change in our production app, and tests are passing again.

hauthorn avatar Feb 18 '17 11:02 hauthorn

I'm also waiting for this PR to be accepted, thanks !

AlexDanault avatar Feb 18 '17 16:02 AlexDanault

Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.

Link: https://twitter.com/maknz/status/833866298232754177

AlexDanault avatar Feb 23 '17 19:02 AlexDanault