slack-laravel icon indicating copy to clipboard operation
slack-laravel copied to clipboard

Published 20 hours ago • verified publisher icon maknz

Fix for Laravel 5.5

Open RohanSakhale opened this issue 7 years ago • 11 comments

RohanSakhale avatar Nov 14 '17 09:11 RohanSakhale

Please update. I'm using your package and i'm getting error

marcinj1 avatar Dec 11 '17 21:12 marcinj1

@skmetaly also listed Laravel 5.5, auto package discovery in composer.json

RohanSakhale avatar Dec 15 '17 05:12 RohanSakhale

I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just composer require phpify/slack-laravel

skecskes avatar Dec 27 '17 01:12 skecskes

The package is no longer being maintained... here is my fork of it..

composer require jeremykenedy/slack-laravel

https://github.com/jeremykenedy/slack-laravel

jeremykenedy avatar Dec 29 '17 22:12 jeremykenedy

This PR worked well for me and fixed the Laravel 5.5 incompatibility issues. It should be accepted. :) Thanks, @RohanSakhale!

qmcree avatar Jan 17 '18 23:01 qmcree

Please merge.

cedricve avatar Mar 18 '18 20:03 cedricve

@skmetaly could you please merge this PR

RohanSakhale avatar May 10 '18 06:05 RohanSakhale

just implemented the same fix on my local and then found the same solution in PR.

dannytrue avatar May 16 '18 17:05 dannytrue

@maknz WTF ARE YOU WAITING FOR TO MERGE THIS.

maurocasas avatar May 18 '18 21:05 maurocasas

@maurocasas You don’t need to wait on him. Just update the dependency in your package manager to be constrained to this specific commit hash.

qmcree avatar May 19 '18 20:05 qmcree

If you took 30 seconds to glance at the README, you'd see this package is no longer being maintained as of early 2017. Use one of the (100+) forks that implements the features you want, or make your own.

Screaming at me to "WTF ARE YOU DOING MERGE THIS" only serves to discourage me from ever contributing open source code again.

maknz avatar Jan 21 '19 20:01 maknz