Adding compatibility for Laravel 5.4

[connorjburton]

[mhamlet]

Maybe release a new version with this fix? I'm using this package to send errors to slack on all my active projects, so they are all breaking on update :)

[bynelus]

Really want the release as well. 😄

[jackmcdade]

Can this be released? It's affecting production and we're having to SSH in and hack files.

[Tlapi]

@jackmcdade If interested, I have created a fork in the meanwhile to fix our app: https://packagist.org/packages/tlapi/slack-laravel

[jackmcdade]

Thanks @Tlapi!

[mdrost]

You could also to your composer.json temporarily add:

"repositories": [
    {
        "type": "vcs",
        "url": "https://github.com/connorjburton/slack-laravel"
    }
 ],

[AlexDanault]

Guys, @maknz said on twitter that he doesn't have time to maintain this package anymore and will soon post a deprecation notice.

Link: https://twitter.com/maknz/status/833866298232754177

[carsonreinke]

@Tlapi any interest in taking this over?

[jonrobinson]

@Tlapi Just FYI your composer package, tlapi/slack-laravel, has the old code in the L5 Service Provider. It's still throwing the "share()" error.

[gdespirito]

I also created a fork for this at https://github.com/freshworkstudio/slack-laravel

You can install it composer require freshwork/slack-laravel

[hotrush]

oh god, still no one working fork?

[mcblum]

@hotrush I just installed @gonzunigad's fork and so far that seems to be working. At least I didn't get the share() error.

[hotrush]

@mcblum only one works for me at 5.4 - jeremykenedy/slack-laravel

[skecskes]

I just made a fork and fixed it there: if anybody is interested: https://github.com/phpify/slack-laravel or just composer require phpify/slack-laravel

[abbood]

@Tlapi i'm still getting this error:

In SlackServiceProviderLaravel5.php line 27:

  Call to undefined method Illuminate\Foundation\Application::share()

after i've included your library.. ideas?

[abbood]

damn @Tlapi! if i run this:

$ composer show tlapi/slack-laravel
name     : tlapi/slack-laravel
descrip. : Laravel 4 and 5 integration for the maknz/slack package, including facades and service providers.
keywords : laravel, slack
versions : * 1.0.0
type     : library
license  : BSD 2-clause "Simplified" License (BSD-2-Clause) (OSI approved) https://spdx.org/licenses/BSD-2-Clause.html#licenseText
source   : [git] https://github.com/Tlapi/slack-laravel.git d62741f731c963c71272159b38f8209ce57ff85b
dist     : [zip] https://api.github.com/repos/Tlapi/slack-laravel/zipball/d62741f731c963c71272159b38f8209ce57ff85b d62741f731c963c71272159b38f8209ce57ff85b
names    : tlapi/slack-laravel

autoload
psr-4
Maknz\Slack\Laravel\ => src/

requires
maknz/slack ~1.0
php >=5.4.0

so your 1.0.0 is pointing to this commit: https://github.com/Tlapi/slack-laravel/commit/d62741f731c963c71272159b38f8209ce57ff85b, but this commit DOESN't actually include the changes, it should be this commit instead: https://github.com/Tlapi/slack-laravel/commit/6d5e9ff218a7ed53c630c2192873087bf6f7fb1d

[abbood]

so adding this worked:

"tlapi/slack-laravel": "dev-master#6d5e9ff218a7ed53c630c2192873087bf6f7fb1d"

see this

$ composer show tlapi/slack-laravel
name     : tlapi/slack-laravel
descrip. : Laravel 4 and 5 integration for the maknz/slack package, including facades and service providers.
keywords : laravel, slack
versions : * dev-master
type     : library
license  : BSD 2-clause "Simplified" License (BSD-2-Clause) (OSI approved) https://spdx.org/licenses/BSD-2-Clause.html#licenseText
source   : [git] https://github.com/Tlapi/slack-laravel.git 6d5e9ff218a7ed53c630c2192873087bf6f7fb1d
dist     : [zip] https://api.github.com/repos/Tlapi/slack-laravel/zipball/6d5e9ff218a7ed53c630c2192873087bf6f7fb1d 6d5e9ff218a7ed53c630c2192873087bf6f7fb1d
names    : tlapi/slack-laravel

autoload
psr-4
Maknz\Slack\Laravel\ => src/

requires
maknz/slack ~1.0
php >=5.4.0