django-leaflet icon indicating copy to clipboard operation
django-leaflet copied to clipboard

Remove unsafe-inline

Open rodolvbg-divineslns opened this issue 4 years ago • 4 comments

#334

rodolvbg-divineslns avatar Jun 22 '21 16:06 rodolvbg-divineslns

Just for history, the line was introduced in 35b3b72bb1f1, but at first sight I cannot see a reason it could not be moved to the css file. :+1:

claudep avatar Jun 22 '21 17:06 claudep

Thanks for the PR :+1: .

It can't be moved in this css file because it is the CSS file directly from leaflet, so it will be lost next time we upgrade it.

We should create a new CSS file to include, such as leaflet/leaflet.extras.css to stay consistent with the JS one.

Gagaro avatar Jun 29 '21 07:06 Gagaro

Ah, of course, how I missed that :-) An extra css is indeed the proper solution.

claudep avatar Jun 29 '21 07:06 claudep

Thanks for the update :+1: , LGTM, you can remove the draft status if you are done with it.

Gagaro avatar Jun 08 '22 10:06 Gagaro