django-geojson icon indicating copy to clipboard operation
django-geojson copied to clipboard

Support backward relationships. Fixes #23 upstream bug

Open dispiste opened this issue 10 years ago • 9 comments
trafficstars

dispiste avatar Jan 14 '15 15:01 dispiste

Thanks for take care of this! The issue has been here for a while :)

Would you mind adding a little test to assert that the behaviour you just fixed will remain fixed forever :) Thanks !

leplatrem avatar Jan 15 '15 08:01 leplatrem

Hi Mathieu, I will try to write the test in the following days. Thanks!

On 15 January 2015 at 09:54, Mathieu Leplatre [email protected] wrote:

Thanks for take care of this! The issue has been here for a while :)

Would you mind adding a little test to assert that the behaviour you just fixed will remain fixed forever :) Thanks !

— Reply to this email directly or view it on GitHub https://github.com/makinacorpus/django-geojson/pull/44#issuecomment-70056240 .


César Martínez Izquierdo GIS developer


Blog: http://geotechnotes.wordpress.com/ ETC-SIA: http://sia.eionet.europa.eu/ Universitat Autònoma de Barcelona (SPAIN)


dispiste avatar Jan 20 '15 19:01 dispiste

Hi @dispiste ! Do you need help to write a small ~~fix~~ test ?

leplatrem avatar Apr 17 '15 10:04 leplatrem

Hi @leplatrem , I have not found the time to write the test yet. I'd be happy if you can write it, or I'll do it when I find a free slot. Thanks!

dispiste avatar Apr 17 '15 10:04 dispiste

This is certainly a much needed fix. I can aid in the test to make this merge if necessary.

aboutaaron avatar Aug 12 '15 00:08 aboutaaron

Thanks @aboutaaron for your proposition!

Yes please! Without test we can't merge this :)

leplatrem avatar Aug 12 '15 08:08 leplatrem

@aboutaaron @dispiste this cannot be merged without tests unfortunately...

leplatrem avatar Feb 08 '16 21:02 leplatrem

Great if you can add the test, I don't currently have the time to do so. Thanks!

On 8 February 2016 at 22:46, Mathieu Leplatre [email protected] wrote:

@aboutaaron https://github.com/aboutaaron @dispiste https://github.com/dispiste this cannot be merged without tests unfortunately...

— Reply to this email directly or view it on GitHub https://github.com/makinacorpus/django-geojson/pull/44#issuecomment-181569900 .


César Martínez Izquierdo GIS developer


SCOLAB: http://www.scolab.es


dispiste avatar Feb 09 '16 12:02 dispiste

I found a workaround... If you want to use the GeoDjango serializer alongside django-geodjango, then go into settings and where you added this (probably years ago)

# settings.py

SERIALIZATION_MODULES = {
    'geojson' : 'djgeojson.serializers'
}

change geojson to djgeojson or something of your liking. If you were using the geojson serializer you'll need to change those references as well. For me, I was not, I was only using the view GeoJSONLayerView.

askpatrickw avatar Jul 20 '18 00:07 askpatrickw