amfora icon indicating copy to clipboard operation
amfora copied to clipboard

Consider shipping release tarball with vendored dependencies

Open illiliti opened this issue 3 years ago • 4 comments

For example, dnscrypt-proxy does this by simply maintaining vendor directory. You can also setup CI to vendor dependencies into release tarball without needing to keep vendor directory within repository. Here is the command that can be used for this: go mod vendor

With vendored dependencies, i can build amfora from source without internet connection by using this command: go build -mod=vendor

illiliti avatar Feb 13 '22 18:02 illiliti

Good idea, thanks. I'll add this for the next release.

makew0rld avatar Mar 09 '22 00:03 makew0rld

PR #299 is one attempt at adding this.

makew0rld avatar Mar 09 '22 00:03 makew0rld

@makeworld-the-better-one has there been any progress on this? Thanks

aabacchus avatar May 29 '22 09:05 aabacchus

Nope I haven't made progress on this. It's still something I'd like to do but not a high priority for me. I made a comment in #299, so if someone made a PR that addresses that comment, I might be able to merge it in.

makew0rld avatar May 29 '22 16:05 makew0rld