amfora icon indicating copy to clipboard operation
amfora copied to clipboard

Amfora themeing updates

Open makew0rld opened this issue 5 years ago • 7 comments

This thread exists so that everyone who has created a theme for Amfora can know when they need to update it. When Amfora adds a new themeable object, like a new modal, it will be announced in this thread. Users who have created themes can subscribe to this thread, and update their themes accordingly.

makew0rld avatar Dec 21 '20 04:12 makew0rld

@sergetymo @bnthor @Skraylet @crdpa @lokesh-krishna You have all contributed themes to Amfora. Please see the above message and subscribe to this thread if you'd like to keep your theme maintained as Amfora improves. Thanks!

makew0rld avatar Dec 21 '20 04:12 makew0rld

For example, v1.7.0 is about to be released. It changes preformatted_text to a light yellow by default, so if you didn't explicitly set that value it will now look different. It also adds the subscription_modal_bg and subscription_modal_text values.

I am wary of changing your themes myself, so if you're interested it'd be appreciated if you made PRs to update them. Thanks! And no worries if you aren't interested in maintaining. Feel free to let me know if you rather I made the updates instead.

makew0rld avatar Dec 21 '20 04:12 makew0rld

Unfortunately i'm not using that theme anymore (Dracula) so if you could update it would be fine. The preformatted_text was already set in the original theme.

I think the new values could just follow the pattern there:

dl_modal_bg = "#282a36" dl_modal_text = "#f8f8f2"

ghost avatar Dec 21 '20 18:12 ghost

@crdpa Okay, thanks for letting me know. I've updated the theme for the subscription modal using those values. This can be seen in d710085. I'll try and maintain the Dracula theme from now on, and you're welcome to take it back at any time by letting me know here.

makew0rld avatar Dec 21 '20 22:12 makew0rld

Thanks. I'll probably come back soon.

Throwing an idea here. Wouldn't be better if amfora could do something like #include in it's config file?

Users could alternate themes just changing one line at the config.

ghost avatar Dec 22 '20 11:12 ghost

Made required additions and changes in #153.

sergetymo avatar Dec 22 '20 13:12 sergetymo

@crdpa Hmm, an include key could be a good idea. Maybe like this:

[theme]
include = "path/to/file.toml"

# Other keys will override the theme

Or were you thinking the key could point to a network location?

Edit: Let's discuss in #154 and not cloud this thread.

makew0rld avatar Dec 22 '20 17:12 makew0rld