SCGAN icon indicating copy to clipboard operation
SCGAN copied to clipboard

difference in preprocessing eye mask

Open hustliujian opened this issue 3 years ago • 4 comments

in the file https://github.com/makeuptransfer/SCGAN/blob/master/SCDataset/SCDataset.py line 125, the preprocess of mask_A has been commented, so it's like

nonmask_eye_np but mask_B is like mask_eye_np mask_A will also be used to remove makeup, so why preprocess them differently?

hustliujian avatar Aug 08 '21 03:08 hustliujian

I also found the this problem.

ixuzhen avatar Oct 05 '21 07:10 ixuzhen

The mask_B will be overwritten later by line 129. I think the code is okay, and commenting the line 126 would be fine.

LiUzHiAn avatar May 24 '22 03:05 LiUzHiAn

Update

Use self.rebound_box() in line 125-126 rather than using self.mask_preprocess() in line 127-130 would generate better results when applying partial makeup transferring. By the way, I found the mask index such as index_A_eye_right and index_A_eye_left seem not to be used in the code.

LiUzHiAn avatar May 25 '22 09:05 LiUzHiAn

Same mask problem resulting the demake-up results very wired around eyes. Could the author check out the problem?

jacquelinelala avatar Aug 01 '22 03:08 jacquelinelala