SCGAN
SCGAN copied to clipboard
difference in preprocessing eye mask
in the file https://github.com/makeuptransfer/SCGAN/blob/master/SCDataset/SCDataset.py line 125, the preprocess of mask_A has been commented, so it's like
but mask_B is like
mask_A will also be used to remove makeup, so why preprocess them differently?
I also found the this problem.
The mask_B will be overwritten later by line 129. I think the code is okay, and commenting the line 126 would be fine.
Update
Use self.rebound_box()
in line 125-126 rather than using self.mask_preprocess()
in line 127-130 would generate better results when applying partial makeup transferring. By the way, I found the mask index such as index_A_eye_right
and index_A_eye_left
seem not to be used in the code.
Same mask problem resulting the demake-up results very wired around eyes. Could the author check out the problem?