Trinamic_TMC2130 icon indicating copy to clipboard operation
Trinamic_TMC2130 copied to clipboard

bug of function set_COOLCONF

Open chaoshuzhe opened this issue 7 years ago • 1 comments

line 727 of Trinamic_TMC2130.cpp should use TMC_COOLCONF_MASKS not TMC_CHOPCONF_MASKS. Is it a typo?

chaoshuzhe avatar May 16 '17 03:05 chaoshuzhe

Apart from that all the COOLCONF altering functions are wrong, ie

uint8_t Trinamic_TMC2130::set_sfilt(uint8_t value)
{
  set_CHOPCONF(TMC_COOLCONF_SFILT, value);

  return _status;
}

which alters the CHOPCONF reg instead of COLLCONF.

hexeguitar avatar Feb 02 '18 08:02 hexeguitar