market-maker-keeper icon indicating copy to clipboard operation
market-maker-keeper copied to clipboard

Published 20 hours ago • verified publisher icon makerdao

Do price rounding better in `sai_maker_otc.py`

Open ghost opened this issue 7 years ago • 2 comments

Due to precision issues, the price rounding mechanism currently used in sai_maker_otc.py doesn't guarantee that a price will always be displayed with the required number of decimal places (e.g. in the Oasis frontend). It may be preferable to round the quantities as well (but to a different number of digits) in order to achieve a consistent number of decimal places.

Authored by @livnev, moved from: https://github.com/makerdao/keeper/issues/35.

ghost avatar Dec 07 '17 18:12 ghost

@reverendus Can this be closed? Doesn't look like this file exists in either repo.

adamjsawicki avatar Jan 22 '20 17:01 adamjsawicki

@Swixx I think this was about this flag https://github.com/makerdao/market-maker-keeper/blob/master/market_maker_keeper/oasis_market_maker_keeper.py#L111 which doesn't seem to be used for anything anymore. So I would say the issue can be closed as it's about a non-existent feature. Having said that it would be nice to remove the flag as well.

ghost avatar Jan 22 '20 22:01 ghost