dss-exec-lib icon indicating copy to clipboard operation
dss-exec-lib copied to clipboard

Published 20 hours ago • verified publisher icon makerdao

Comment CollateralOpts & update README.md

Open canokaue opened this issue 4 years ago • 2 comments

  • create variable comments in CollateralOpts.sol;
  • add breakerTolerance, kprFlatReward & kprPctReward variables to README.md examples;
  • add setIlkAutoLineParameter method call to README.md example;
  • change initStairstepExponentialDecrease to setStairstepExponentialDecrease;
  • match Maker governance proposal parameters with CollateralOpts.

canokaue avatar Nov 30 '21 22:11 canokaue

Hey @brianmcmichael thank you so much for the feedback! I've added your suggestions to the latest commit 6ad733d4050bb9234b84ac81c400c052c21fa107, please let me know if it's all good now. Have a great week.

canokaue avatar Jan 17 '22 12:01 canokaue

@brianmcmichael @iamchrissmith thanks for reviewing and approving the PR. I believe we're good to merge, but I can't do it on my end.

canokaue avatar Mar 09 '22 14:03 canokaue