community icon indicating copy to clipboard operation
community copied to clipboard

Image on Docs not loading due to Case-Sensitivity

Open NessDan opened this issue 2 years ago • 1 comments

Attention (CC)

Summary of changes

Your image's file name had an extension in ALL CAPS so it doesn't load on your documentation site:

image

Now that the file name is lowercase, it'll load properly:

(After my fix:) image

Description of the changes included in this pull request. Steps to follow to confirm the feature is completed or the bug/issue is resolved. Are there any dependencies? Does this code break any existing functionality or introduce any risk?

Relevant Context

  • Feature: [ticket number](link to project management ticket)
  • Relevant Pull Request: #

How Has This Been Tested?

Screenshots (if appropriate):

Further comments


Types of changes

  • [x] Content edit, File upload, content addition
  • [x] Bug fix (non-breaking change which fixes an issue)
  • [ ] New feature (non-breaking change which adds functionality)
  • [x] Code style update (formatting, renaming)
  • [ ] Refactoring (no functional changes, no api changes)
  • [ ] Build related changes
  • [x] Technical Documentation Update
  • [ ] Other (please describe):

Does this introduce a breaking change?

Breaking change is defined as "A fix or feature that would cause existing functionality to change."

  • [ ] Yes
  • [x] No

Checklist:

  • [x] My code follows the code style of this project.
  • [x] I have added tests that prove my fix is effective or that my feature works
  • [x] I have added/changed necessary documentation (if appropriate)
  • [x] All new and existing tests passed.

NessDan avatar Jun 10 '22 19:06 NessDan

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
community ✅ Ready (Inspect) Visit Preview Jun 10, 2022 at 7:36PM (UTC)

vercel[bot] avatar Jun 10 '22 19:06 vercel[bot]

Thank you, these docs are no longer actively supported so I am closing this PR.

ghost avatar Jan 19 '23 15:01 ghost

Are docs moving somewhere @patrick-j-govalpha or is MakerDAO disolving?

NessDan avatar Jan 20 '23 05:01 NessDan

docs have moved mostly to manual.makerdao.com

the relevant repo is: https://github.com/makerdao/governance-manual

ghost avatar Jan 20 '23 12:01 ghost